Re: [PATCH 3/4] arm64: dts: zii-ultra: Add node for accelerometer

From: Shawn Guo
Date: Sun Oct 27 2019 - 20:47:05 EST


On Sat, Oct 26, 2019 at 11:54:13AM -0700, Andrey Smirnov wrote:
> On Sat, Oct 26, 2019 at 4:55 AM Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
> >
> > On Tue, Oct 15, 2019 at 08:26:53AM -0700, Andrey Smirnov wrote:
> > > Add I2C node for accelerometer present on both Zest and RMB3 boards.
> > >
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> > > Cc: Fabio Estevam <festevam@xxxxxxxxx>
> > > Cc: Chris Healy <cphealy@xxxxxxxxx>
> > > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > > ---
> > > .../boot/dts/freescale/imx8mq-zii-ultra.dtsi | 18 ++++++++++++++++++
> > > 1 file changed, 18 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > index 21eb52341ba8..8395c5a73ba6 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > @@ -262,6 +262,18 @@
> > > pinctrl-0 = <&pinctrl_i2c1>;
> > > status = "okay";
> > >
> > > + accel@1c {
> >
> > s/accel/accelerometer
> >
> > I fixed it up and applied the series.
> >
>
> I'm fine with that change, but FYI, I originally had it as
> "accelerometer', but changed to "accel" to match the name in DT for
> RDU2.

We should change RDU2 instead, IMO.

Shawn