Re: [PATCH 2/4] ACPI / PMIC: Add byt prefix to Crystal Cove PMIC OpRegion driver

From: Rafael J. Wysocki
Date: Fri Oct 25 2019 - 05:49:20 EST


On Fri, Oct 25, 2019 at 11:33 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, Oct 25, 2019 at 10:59:06AM +0200, Hans de Goede wrote:
> > On 25-10-2019 09:41, Andy Shevchenko wrote:
> > > On Thu, Oct 24, 2019 at 11:38:25PM +0200, Hans de Goede wrote:
>
> > > I would go with previously established pattern, i.e. intel_pmic_bytcc.c.
>
> > Well that would be consistent with the chtwc for the Whiskey Cove, but
> > Crystal Cove related files are shortened to crc in many places already:
> >
> > Filenames before this patch:
> > drivers/acpi/pmic/intel_pmic_crc.c
> > drivers/pwm/pwm-crc.c
> > drivers/mfd/intel_soc_pmic_crc.c
> >
> > And to me "cc" stands for the Type-C cc lines, or for Cc: from email,
> > so IMHO it is best to stick with crc here.
>
> Okay, let's do an exception here due to the fact the code and name already
> exists and spreads enough thru sources.
>
> It means you may use mine tags.

OK, applying the series as 5.5 material, thanks!