Re: [PATCH] x86/hyper-v: micro-optimize send_ipi_one case

From: Roman Kagan
Date: Fri Oct 25 2019 - 05:41:43 EST


On Fri, Oct 25, 2019 at 12:38:05AM +0200, Thomas Gleixner wrote:
> On Thu, 24 Oct 2019, Roman Kagan wrote:
> > > +
> > > + if (cpu >= 64)
> > > + goto do_ex_hypercall;
> > > +
> > > + ret = hv_do_fast_hypercall16(HVCALL_SEND_IPI, vector,
> > > + BIT_ULL(hv_cpu_number_to_vp_number(cpu)));
> > > + return ((ret == 0) ? true : false);
> >
> > D'oh. Isn't "return ret == 0;" or just "return ret;" good enough?
>
> 'return ret == 0' != 'return ret'
>
> !ret perhaps :)

Sure. Time to vacuum my keyboard ;)

Thanks,
Roman.