Re: [PATCH v6 02/10] iommu/vt-d: Add custom allocator for IOASID

[Lu Baolu]

Hi,

On 10/24/19 7:01 AM, Jacob Pan wrote:
> On Wed, 23 Oct 2019 10:21:51 +0800
> Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> wrote:
>
> > > > +#ifdef CONFIG_INTEL_IOMMU_SVM
> > >
> > > Maybe move them to intel-svm.c instead? that's where the bulk
> > > of the svm support is?
> >
> > I think this is a generic PASID allocator for guest IOMMU although
> > vSVA is currently the only consumer. Instead of making it SVM
> > specific, I'd like to suggest moving it to intel-pasid.c and replace
> > the @svm parameter with a void * one in intel_ioasid_free().
>
> make sense to use void*, no need to tie that to svm bind data type.
>
> In terms of location, perhaps we can move if we have more consumers of
> custom allocator?

Make sense to me.

Best regards,
baolu