Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

[Steven Rostedt]

On Thu, 24 Oct 2019 12:16:09 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Wed, Oct 23, 2019 at 02:52:45PM -0400, Steven Rostedt wrote:
> > After applying this series and this patch I triggered this:  
> 
> Bah, I hate C.
> 
> (also for some reason I had KPROBE_EVENTS disabled, when I enabled it it
> failed on boot due to selftests)
> 
> this one seems to boot and survive your selftests thing (that takes for
> bloody ever to run).
> 

Care to enable CONFIG_HIST_TRIGGERS?

  CC [M]  drivers/gpu/drm/i915/gem/i915_gem_context.o
/work/git/linux-trace.git/kernel/trace/trace_events_hist.c: In function âregister_synth_eventâ:
/work/git/linux-trace.git/kernel/trace/trace_events_hist.c:1157:15: error: âstruct trace_event_classâ has no member named âdefine_fieldsâ; did you mean âget_fieldsâ?
  call->class->define_fields = synth_event_define_fields;
               ^~~~~~~~~~~~~
               get_fields
make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:265: kernel/trace/trace_events_hist.o] Error 1
make[3]: *** Waiting for unfinished jobs....

-- Steve