Re: [PATCH] irqchip: Skip contexts other supervisor in plic_init()

From: Marc Zyngier
Date: Thu Oct 24 2019 - 03:27:57 EST


On 2019-10-24 08:03, Christoph Hellwig wrote:
On Thu, Oct 24, 2019 at 07:51:16AM +0100, Marc Zyngier wrote:
> > > Will this need to change for RISC-V M-mode Linux support?
> > >
> > > https://lore.kernel.org/linux-riscv/20191017173743.5430-1-hch@xxxxxx/
> >
> > Yes.
>
> For M-mode we'll want to check IRQ_M_EXT above. So we should just
> merge this patch ASAP and then for my rebased M-mode series I'll
> fix the check to do that for the M-Mode case, which is much cleaner
> than my hack.

Does this need to be taken as a fix, potentially Cc to stable? Or is
that 5.5 material?

So I though that the S-mode context were kinda aways to be sorted before
M-mode, but I can't find anything guranteeing it. So I think this
actually is a fix, and getting this queued up in the next -rc would
really help me with the nommu stuff - otherwise we'd need to take it
through the riscv tree for 5.5 to avoid conflicts.

Btw, here is my:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

for the patch.

Thanks for that.

Alan, if you can respin this patch with an updated commit message, I'll queue
it with a couple of other nits I have lying around, and send it to Thomas by
the end of the week.

M.
--
Jazz is not dead. It just smells funny...