Re: [PATCH] drm/panfrost: fix -Wmissing-prototypes warnings

From: Steven Price
Date: Mon Oct 21 2019 - 09:19:42 EST


On 19/10/2019 08:28, Yi Wang wrote:
> We get these warnings when build kernel W=1:
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:35:6: warning: no previous prototype for âpanfrost_perfcnt_clean_cache_doneâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:40:6: warning: no previous prototype for âpanfrost_perfcnt_sample_doneâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:190:5: warning: no previous prototype for âpanfrost_ioctl_perfcnt_enableâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:218:5: warning: no previous prototype for âpanfrost_ioctl_perfcnt_dumpâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:250:6: warning: no previous prototype for âpanfrost_perfcnt_closeâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:264:5: warning: no previous prototype for âpanfrost_perfcnt_initâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c:320:6: warning: no previous prototype for âpanfrost_perfcnt_finiâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_mmu.c:227:6: warning: no previous prototype for âpanfrost_mmu_flush_rangeâ [-Wmissing-prototypes]
> drivers/gpu/drm/panfrost/panfrost_mmu.c:435:5: warning: no previous prototype for âpanfrost_mmu_map_fault_addrâ [-Wmissing-prototypes]
>
> For file panfrost_mmu.c, make functions static to fix this.
> For file panfrost_perfcnt.c, include head file can fix this.

Nit: s/head/header/

>
> Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx>

Looks good, just a few minor style issues (below), with those fixed:

Reviewed-by: Steven Price <steven.price@xxxxxxx>

> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 +++--
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 1 +
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index bdd9905..d0458a5 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -224,7 +224,7 @@ static size_t get_pgsize(u64 addr, size_t size)
> return SZ_2M;
> }
>
> -void panfrost_mmu_flush_range(struct panfrost_device *pfdev,
> +static void panfrost_mmu_flush_range(struct panfrost_device *pfdev,
> struct panfrost_mmu *mmu,
> u64 iova, size_t size)

Please align the arguments with the '(' as it was before.

> {
> @@ -432,7 +432,8 @@ void panfrost_mmu_pgtable_free(struct panfrost_file_priv *priv)
>
> #define NUM_FAULT_PAGES (SZ_2M / PAGE_SIZE)
>
> -int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, u64 addr)
> +static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as,
> + u64 addr)

Again, align 'addr' with the '('.

> {
> int ret, i;
> struct panfrost_gem_object *bo;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c
> index 83c57d3..7493dc0 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c
> @@ -17,6 +17,7 @@
> #include "panfrost_job.h"
> #include "panfrost_mmu.h"
> #include "panfrost_regs.h"
> +#include "panfrost_perfcnt.h"

Please keep header includes sorted alphabetically.

Thanks,

Steve

>
> #define COUNTERS_PER_BLOCK 64
> #define BYTES_PER_COUNTER 4
>