Re: [PATCH] KVM: remove redundant code in kvm_arch_vm_ioctl

From: Paolo Bonzini
Date: Mon Oct 21 2019 - 04:56:24 EST


On 21/10/19 10:16, Thomas Gleixner wrote:
> Can you please get rid of that odd jump label completely?
>
> if (irqchip_kernel(kvm))
> r = kvm_vm_ioctl_set_irqchip(kvm, chip);

Keeping the label has the advantage of making the get and set cases a
bit more similar (the get case has to do a copy_to_user after
kvm_vm_ioctl_get_irqchip returns). Unfortunately struct kvm_irqchip is
quite big (520 bytes) so we don't allocate it on the stack.

So I queued Miaohe's patch.

Paolo