Re: [PATCH 15/15] riscv: disable the EFI PECOFF header for M-mode

From: Anup Patel
Date: Fri Oct 18 2019 - 00:54:53 EST


On Thu, Oct 17, 2019 at 11:08 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> No point in bloating the kernel image with a bootloader header if
> we run bare metal.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> arch/riscv/kernel/head.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S
> index 71efbba25ed5..dc21e409cc49 100644
> --- a/arch/riscv/kernel/head.S
> +++ b/arch/riscv/kernel/head.S
> @@ -16,6 +16,7 @@
>
> __INIT
> ENTRY(_start)
> +#ifndef CONFIG_RISCV_M_MODE
> /*
> * Image header expected by Linux boot-loaders. The image header data
> * structure is described in asm/image.h.
> @@ -47,6 +48,7 @@ ENTRY(_start)
>
> .global _start_kernel
> _start_kernel:
> +#endif /* CONFIG_RISCV_M_MODE */
> /* Mask all interrupts */
> csrw CSR_XIE, zero
> csrw CSR_XIP, zero
> --
> 2.20.1
>

LGTM.

Reviewed-by: Anup Patel <anup@xxxxxxxxxxxxxx>

Regards,
Anup