Re: [v3,1/2] dt-bindings: i2c: support property idle-state

From: Rob Herring
Date: Thu Oct 17 2019 - 12:46:04 EST


On Thu, Oct 17, 2019 at 10:38 AM Peter Rosin <peda@xxxxxxxxxx> wrote:
>
> On 2019-10-16 06:09, Biwen Li wrote:
> > This supports property idle-state
> >
> > Signed-off-by: Biwen Li <biwen.li@xxxxxxx>
> > ---
> > Change in v3:
> > - update subject and description
> > - add some information for property idle-state
> >
> > Change in v2:
> > - update subject and description
> > - add property idle-state
> >
> > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > index 30ac6a60f041..7abda506b828 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> > @@ -25,6 +25,8 @@ Required Properties:
> > Optional Properties:
> >
> > - reset-gpios: Reference to the GPIO connected to the reset input.
> > + - idle-state: if present, overrides i2c-mux-idle-disconnect,
> > + Please refer to Documentation/devicetree/bindings/mux/mux-controller.txt
> > - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all
> > children in idle state. This is necessary for example, if there are several
> > multiplexers on the bus and the devices behind them use same I2C addresses.
> >
>
> Rob, should i2c-mux-idle-disconnect perhaps be deprecated here? Is that
> appropriate?
>
> idle-state provides a super-set of what i2c-mux-idle-disconnect provides.

Yes, seems like it and it is not too widely used.

Rob