RE: [PATCH 5/7] regulator: da9211: switch to using devm_fwnode_gpiod_get

From: Adam Thomson
Date: Mon Oct 07 2019 - 06:43:25 EST


On 05 October 2019 00:10, Dmitry Torokhov wrote:

> devm_gpiod_get_from_of_node() is being retired in favor of
> devm_fwnode_gpiod_get_index(), that behaves similar to
> devm_gpiod_get_index(), but can work with arbitrary firmware node. It
> will also be able to support secondary software nodes.
>
> Let's switch this driver over.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>

> ---
>
> drivers/regulator/da9211-regulator.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-
> regulator.c
> index bf80748f1ccc..523dc1b95826 100644
> --- a/drivers/regulator/da9211-regulator.c
> +++ b/drivers/regulator/da9211-regulator.c
> @@ -283,12 +283,12 @@ static struct da9211_pdata
> *da9211_parse_regulators_dt(
>
> pdata->init_data[n] = da9211_matches[i].init_data;
> pdata->reg_node[n] = da9211_matches[i].of_node;
> - pdata->gpiod_ren[n] = devm_gpiod_get_from_of_node(dev,
> - da9211_matches[i].of_node,
> - "enable-gpios",
> - 0,
> - GPIOD_OUT_HIGH |
> GPIOD_FLAGS_BIT_NONEXCLUSIVE,
> - "da9211-enable");
> + pdata->gpiod_ren[n] = devm_fwnode_gpiod_get(dev,
> + of_fwnode_handle(pdata-
> >reg_node[n]),
> + "enable",
> + GPIOD_OUT_HIGH |
> +
> GPIOD_FLAGS_BIT_NONEXCLUSIVE,
> + "da9211-enable");
> if (IS_ERR(pdata->gpiod_ren[n]))
> pdata->gpiod_ren[n] = NULL;
> n++;
> --
> 2.23.0.581.g78d2f28ef7-goog