Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

From: Mathias Nyman
Date: Mon Oct 07 2019 - 04:12:02 EST


On 7.10.2019 10.21, Carlo Caione wrote:
Hi,
I bisected an issue down to commit f7fac17ca925 "xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()".

Setup:
XPS 9370 + Thunderbolt dock Dell TB16

Issue:
The laptop is unable to go to sleep. It never really goes to sleep and after a few seconds the USB dies.

Log:
https://termbin.com/icix

Cheers!


Does the below patch help? Greg just applied it to his usb-linus branch.

ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend()
Link: https://lore.kernel.org/r/1570190373-30684-8-git-send-email-mathias.nyman@xxxxxxxxxxxxxxx

-Mathias