Re: [RFC PATCH] scripts: Fix coccicheck failed

From: Yuehaibing
Date: Sun Oct 06 2019 - 00:24:09 EST




On 2019/10/4 10:32, Masahiro Yamada wrote:
> On Thu, Oct 3, 2019 at 9:23 PM Julia Lawall <julia.lawall@xxxxxxx> wrote:
>>
>>
>>
>> On Thu, 3 Oct 2019, Masahiro Yamada wrote:
>>
>>> On Tue, Oct 1, 2019 at 10:01 PM Julia Lawall <julia.lawall@xxxxxxx> wrote:
>>>>> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/misc/add_namespace.cocci
>>>>> index c832bb6445a8..99e93a6c2e24 100644
>>>>> --- a/scripts/coccinelle/misc/add_namespace.cocci
>>>>> +++ b/scripts/coccinelle/misc/add_namespace.cocci
>>>>> @@ -6,6 +6,8 @@
>>>>> /// add a missing namespace tag to a module source file.
>>>>> ///
>>>>>
>>>>> +virtual report
>>>>> +
>>>>> @has_ns_import@
>>>>> declarer name MODULE_IMPORT_NS;
>>>>> identifier virtual.ns;
>>>>>
>>>>>
>>>>>
>>>>> Adding virtual report make the coccicheck go ahead smoothly.
>>>>
>>>> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
>>>>
>>>
>>>
>>> Was this patch posted somewhere?
>>
>> It was probably waiting for moderation in the cocci mailing list. Do you
>> have it now (or in a few minutes)?
>
> No. I do not see it yet.
>
> I want to pick the patch from LKML Patchwork
> https://lore.kernel.org/patchwork/project/lkml/list/
>
> You gave Acked-by to the one-liner fix "virtual report",
> and I am happy to apply it to my tree.
>
> YueHaibing, could you submit it as a patch?

Sorry for late, will send it.

>
>