Re: [PATCH v2] mtd: onenand: prevent memory leak in onenand_scan

From: Markus Elfring
Date: Sat Oct 05 2019 - 10:05:00 EST


> In onenand_scan if scan_bbt fails the allocated buffers for oob_buf,
> verify_buf, and page_buf should be released.

Can a wording like the following be nicer for the change description?

Release the memory for the buffers âoob_bufâ, âverify_bufâ and âpage_bufâ
after a call of the function âscan_bbtâ failed in the implementation
of the function âonenand_scanâ.


> Fixes: 5988af231978 ("mtd: Flex-OneNAND support")
â
> ---
> Changes in v2:
â
> for the hint).

Did you take another review comment into account for this patch change log?


> ---

Please replace the delimiter at this place by a blank line in subsequent messages.


> drivers/mtd/nand/onenand/onenand_base.c | 8 +++++++-
â


Regards,
Markus