Re: [PATCH v2] ethernet: gemini: Use devm_platform_ioremap_resource() in gemini_ethernet_probe()

From: Linus Walleij
Date: Fri Oct 04 2019 - 17:08:18 EST


On Fri, Sep 20, 2019 at 11:23 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 20 Sep 2019 10:52:56 +0200
>
> Simplify this function implementation by using the wrapper function
> âdevm_platform_ioremap_resourceâ instead of calling the functions
> âplatform_get_resourceâ and âdevm_ioremap_resourceâ directly.
>
> * Thus reduce also a bit of exception handling code here.
> * Delete the local variable âresâ.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Seems correct.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

BR
Linus Walleij