Re: [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon

From: Bob Peterson
Date: Fri Oct 04 2019 - 13:22:09 EST


----- Original Message -----
> ----- Original Message -----
> > From: Aliasgar Surti <aliasgar.surti500@xxxxxxxxx>
> >
> > There is use of unnecessary semicolon after switch case.
> > Removed the semicolon.
> >
> > Signed-off-by: Aliasgar Surti <aliasgar.surti500@xxxxxxxxx>
> > ---
> > fs/gfs2/recovery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> > index c529f8749a89..f4aa8551277b 100644
> > --- a/fs/gfs2/recovery.c
> > +++ b/fs/gfs2/recovery.c
> > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
> >
> > default:
> > goto fail;
> > - };
> > + }
> >
> > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> > --
> > 2.17.1
>
> Hi,
>
> Thanks for the patch. I did a quick search and found two more:
>
> glops.c- break;
> glops.c: };
>
> inode.c- goto out_gunlock;
> inode.c: };
>
> Do you want to include those in your patch and re-submit it or
> should I cook up a second patch?

Hi,

I just went ahead and added the two above to your patch and pushed
it to for-next. Thanks.

Regards,

Bob Peterson