Re: [PATCH v3 0/2] hwrng: npcm: add NPCM RNG driver support

From: Herbert Xu
Date: Fri Oct 04 2019 - 11:30:39 EST


On Thu, Sep 12, 2019 at 12:01:47PM +0300, Tomer Maimon wrote:
> This patch set adds Random Number Generator (RNG) support
> for the Nuvoton NPCM Baseboard Management Controller (BMC).
>
> The RNG driver we use power consumption when the RNG
> is not required.
>
> The NPCM RNG driver tested on NPCM750 evaluation board.
>
> Addressed comments from:.
> - Daniel Thompson: https://lkml.org/lkml/2019/9/10/352
> - Milton Miller II : https://lkml.org/lkml/2019/9/10/847
> - Daniel Thompson: https://lkml.org/lkml/2019/9/10/294
>
> Changes since version 2:
> - Rearrange wait parameter in npcm_rng_read function.
> - Calling pm_runtime_enable function before hwrng_register function
> called to enable the hwrng before add_early_randomness called.
> - Remove quality dt-binding parameter in the driver and documentation.
> - Disable CONFIG_PM if devm_hwrng_register failed.
> - Remove owner setting in the driver struct.
>
> Changes since version 1:
> - Define timout in real-world units.
> - Using readl_poll_timeout in rng_read function.
> - Honor wait parameter in rng_read function.
> - Using local variable instead of #ifndef.
> - Remove probe print.
>
> Tomer Maimon (2):
> dt-binding: hwrng: add NPCM RNG documentation
> hwrng: npcm: add NPCM RNG driver
>
> .../bindings/rng/nuvoton,npcm-rng.txt | 12 ++
> drivers/char/hw_random/Kconfig | 13 ++
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/npcm-rng.c | 186 ++++++++++++++++++
> 4 files changed, 212 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> create mode 100644 drivers/char/hw_random/npcm-rng.c

All applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt