Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

[Sasha Levin]

On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote:
> On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote:
> > From: Vadim Sukhomlinov <sukhomlinov@xxxxxxxxxx>
> >
> > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream
> >
> > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
> > future TPM operations. TPM 1.2 behavior was different, future TPM
> > operations weren't disabled, causing rare issues. This patch ensures
> > that future TPM operations are disabled.
> >
> > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Vadim Sukhomlinov <sukhomlinov@xxxxxxxxxx>
> > [dianders: resolved merge conflicts with mainline]
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/char/tpm/tpm-chip.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
>
> What kernel version(s) is this for?

It would go to 4.19, we've recently reverted an incorrect backport of
this patch.

Jarkko, why is this patch 3/3? We haven't seen the first two on the
mailing list, do we need anything besides this patch?

--
Thanks,
Sasha