Re: [PATCH v6 1/9] dt-bindings: ibm,secureboot: secure boot specific properties for PowerNV

[Nayna]

On 10/01/2019 09:33 AM, Rob Herring wrote:
> On Fri, Sep 27, 2019 at 10:25:52AM -0400, Nayna Jain wrote:
> > PowerNV represents both the firmware and Host OS secureboot state of the
> > system via device tree. This patch adds the documentation to give
> > the definition of the nodes and the properties.
> >
> > Signed-off-by: Nayna Jain <nayna@xxxxxxxxxxxxx>
> > ---
> >   .../bindings/powerpc/ibm,secureboot.rst       | 76 ++++++++++++++++
> >   .../devicetree/bindings/powerpc/secvar.rst    | 89 +++++++++++++++++++
> >   2 files changed, 165 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/powerpc/ibm,secureboot.rst
> >   create mode 100644 Documentation/devicetree/bindings/powerpc/secvar.rst
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/ibm,secureboot.rst b/Documentation/devicetree/bindings/powerpc/ibm,secureboot.rst
> > new file mode 100644
> > index 000000000000..03d32099d2eb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/ibm,secureboot.rst
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: GPL-2.0
> Not the right form for reST files.
>
> > +*** NOTE ***
> > +This document is copied from OPAL firmware
> > +(skiboot/doc/device-tree/ibm,secureboot.rst)
> Why copy into the kernel?

Do you mean we do not need the device-tree documentation in the kernel 
when it already exists in the skiboot tree ?

I think I am ok with that. Michael, what do you think ?

Thanks & Regards,
ÂÂÂÂ - Nayna