Re: [PATCH 0/3] tegra: use regulator_bulk_set_supply_names()

From: Thierry Reding
Date: Tue Oct 01 2019 - 09:38:14 EST


On Tue, Oct 01, 2019 at 03:23:30PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> The regulator_bulk_set_supply_names() helper was merged upstream. Use it
> in a couple tegra drivers.
>
> Bartosz Golaszewski (3):
> ahci: tegra: use regulator_bulk_set_supply_names()
> phy: tegra: use regulator_bulk_set_supply_names()
> usb: host: xhci-tegra: use regulator_bulk_set_supply_names()
>
> drivers/ata/ahci_tegra.c | 6 +++---
> drivers/phy/tegra/xusb.c | 6 +++---
> drivers/usb/host/xhci-tegra.c | 5 +++--
> 3 files changed, 9 insertions(+), 8 deletions(-)

I really don't see the point here. You've got a positive diffstat here,
which means all that churn is without benefit.

Is there some subsequent work based on this that will actually improve
things?

Thierry

Attachment: signature.asc
Description: PGP signature