Re: [RFC PATCH 07/22] thunderbolt: Add default linking between ports if not provided by DROM

From: Mika Westerberg
Date: Tue Oct 01 2019 - 09:14:51 EST


On Tue, Oct 01, 2019 at 02:39:11PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 01, 2019 at 02:38:15PM +0300, Mika Westerberg wrote:
> > Some cases the DROM information is not correct or is simply missing.
>
> What is "DROM"?

It is "Device ROM". Essentially per-device information. I will spell it
out in next version.

> > This prevents establishing lane bonding even if it would be possible
> > otherwise. To make this work better provide default linking between
> > ports if DROM has not provided that information.
> >
> > This works with legacy devices where ports 1 and 2, and 3 and 4 are
> > linked together and also with USB4.
>
> "linked together" as in "bonded"? Or something else? Names are getting
> confusing here :(

Here linked together means the both port in dual link so ports 1, 2 and
ports 3 and 4. There are always two pairs of ports (lanes) that go out
of physical connector. Here we just link them in software. I'll try to
clarify this in the next version.