RE: [PATCH v2] Drivers: hv: vmbus: Fix harmless building warnings without CONFIG_PM_SLEEP

From: Michael Kelley
Date: Fri Sep 20 2019 - 13:41:35 EST


From: Dexuan Cui <decui@xxxxxxxxxxxxx> Sent: Thursday, September 19, 2019 2:46 PM
>
> If CONFIG_PM_SLEEP is not set, we can comment out these functions to avoid
> the below warnings:
>
> drivers/hv/vmbus_drv.c:2208:12: warning: âvmbus_bus_resumeâ defined but not used [-
> Wunused-function]
> drivers/hv/vmbus_drv.c:2128:12: warning: âvmbus_bus_suspendâ defined but not used [-
> Wunused-function]
> drivers/hv/vmbus_drv.c:937:12: warning: âvmbus_resumeâ defined but not used [-
> Wunused-function]
> drivers/hv/vmbus_drv.c:918:12: warning: âvmbus_suspendâ defined but not used [-
> Wunused-function]
>
> Fixes: 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for
> hibernation")
> Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself for
> hibernation")
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> ---
>
> In v2:
> test CONFIG_PM_SLEEP rather than CONFIG_PM. Thanks, Arnd!
>
> drivers/hv/vmbus_drv.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>

Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>