Re: [PATCH] drivers:staging:rtl8723bs: Removed unneeded variables

From: Dan Carpenter
Date: Tue Sep 17 2019 - 10:45:23 EST


On Tue, Sep 17, 2019 at 08:01:31PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@xxxxxxxxx>
>
> coccicheck reported warning for unneeded variable used.
>
> This patch removes the unneeded variables.
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index d1b199e..fa3ffc3 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -2428,8 +2428,7 @@ static int rtw_drvext_hdl(struct net_device *dev, struct iw_request_info *info,
> static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> {
> - int ret = 0;
> - return ret;
> + return 0;
> }

Just get rid of the whole function. Replace the pointer in the function
array with a NULL.

regards,
dan carpenter