Re: [PATCH v2 1/2] mtd: spi-nor: intel-spi: support chips without software sequencer

From: Jethro Beekman
Date: Mon Sep 16 2019 - 05:12:56 EST


On 2019-09-16 11:11, Mika Westerberg wrote:
> Hi,
>
> On Sun, Sep 15, 2019 at 08:41:55PM +0000, Jethro Beekman wrote:
>> Could someone please review this?
>>
>> On 2019-09-04 03:15, Jethro Beekman wrote:
>>> Some flash controllers don't have a software sequencer. Avoid
>>> configuring the register addresses for it, and double check
>>> everywhere that its not accidentally trying to be used.
>
> All the supported types in intel_spi_init() set ->sregs so I don't see
> how we could end up calling functions with that not set properly. Which
> controller we are talking about here? CNL?
>

Yes, see 2/2.

--
Jethro Beekman | Fortanix