Re: [PATCH 6/8] x86/platform/uv: Decode UVsystab Info

[Sasha Levin]

On Thu, Sep 05, 2019 at 04:16:34PM +0200, Greg KH wrote:
> On Thu, Sep 05, 2019 at 08:02:58AM -0500, Mike Travis wrote:
> > --- linux.orig/arch/x86/kernel/apic/x2apic_uv_x.c
> > +++ linux/arch/x86/kernel/apic/x2apic_uv_x.c
> > @@ -1303,7 +1303,8 @@ static int __init decode_uv_systab(void)
> >  	struct uv_systab *st;
> >  	int i;
> >
> > -	if (uv_hub_info->hub_revision < UV4_HUB_REVISION_BASE)
> > +	/* Select only UV4 (hubbed or hubless) and higher */
> > +	if (is_uv_hubbed(-2) < uv(4) && is_uv_hubless(-2) < uv(4))

For someone not too familiar with the code, this is completely
unreadable. There must be a nicer way to do this.

--
Thanks,
Sasha