Re: [PATCH 4.9 07/83] ASoC: Fail card instantiation if DAI format setup fails

From: Mark Brown
Date: Wed Sep 04 2019 - 15:05:42 EST


On Wed, Sep 04, 2019 at 08:35:27PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 04, 2019 at 07:10:27PM +0100, Mark Brown wrote:

> > I nacked this patch when Sasha posted it - it only improves diagnostics
> > and might make systems that worked by accident break since it turns
> > things into a hard failure, it won't make anything that didn't work
> > previously work.

> This is already in the 4.14.141, 4.19.69, and 5.2.11 releases, have you
> heard any problems there?

Ugh, how did that happen? I've not heard any reports but I'd be a lot
more comfortable if this was reverted, these releases haven't been out
that long and the users who'd be affected are mostly doing embedded
stuff.

> I'll be glad to drop this from the 4.9.y and 4.4.y queues, now if you
> wish, but just want you to know it's already out there in some releases.

Yes, please.

Attachment: signature.asc
Description: PGP signature