Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board

From: Philippe CORNU
Date: Mon Sep 02 2019 - 04:45:42 EST


Hi Yannick,

On 8/2/19 4:08 PM, Yannick Fertrà wrote:
> The ltdc pinctrl must be in the display controller node and
> not in the peripheral node (hdmi bridge).
>
> Signed-off-by: Yannick Fertrà <yannick.fertre@xxxxxx>
> ---
> arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index f3f0e37..1285cfc 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -99,9 +99,6 @@
> reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
> interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpiog>;
> - pinctrl-names = "default", "sleep";
> - pinctrl-0 = <&ltdc_pins_a>;
> - pinctrl-1 = <&ltdc_pins_sleep_a>;
> status = "okay";
>
> ports {
> @@ -276,6 +273,9 @@
> };
>
> &ltdc {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&ltdc_pins_a>;
> + pinctrl-1 = <&ltdc_pins_sleep_a>;

Reviewed-by: Philippe Cornu <philippe.cornu@xxxxxx>

Thanks
Philippe :)

> status = "okay";
>
> port {
>