Re: [PULL REQUEST] Please pull rdma.git

From: Doug Ledford
Date: Fri Aug 23 2019 - 15:14:24 EST


Hi Linus,

I didn't notice I was on my personal email identity when I sent the pull
request. Sorry about that. It's really me ;-)

On Fri, 2019-08-23 at 14:48 -0400, Doug Ledford wrote:
> Hi Linus,
>
> No beating around the bush: this is a monster pull request for an -rc5
> kernel. Intel hit me with a series of fixes for TID processing.
> Mellanox hit me with a series for their UMR memory support.
>
> And we had one fix for siw that fixes the 32bit build warnings and
> because of the number of casts that had to be changed to properly
> silence the warnings, that one patch alone is a full 40% of the LOC of
> this entire pull request. Given that this is the initial release
> kernel
> for siw, I'm trying to fix anything in it that we can, so that adds to
> the impetus to take fixes for it like this one.
>
> I had to do a rebase early in the week. Jason had thought he put a
> patch on the rc queue that he needed to be there so he could base some
> work off of it, and it had actually not been placed there. So he
> asked
> me (on Tuesday) to fix that up before pushing my wip branch to the
> official rc branch. I did, and that's why the early patches look like
> they were all committed at the same time on Tuesday. That bunch had
> been in my queue prior.
>
> The various patches all pass my test for being legitimate fixes and
> not
> attempts to slide new features or development into a late rc. Well,
> they were all fixes with the exception of a couple clean up patches
> people wrote for making the fixes they also wrote better (like a
> cleanup
> patch to move UMR checking into a function so that the remaining UMR
> fix
> patches can reference that function), so I left those in place too.
>
> My apologies for the LOC count and the number of patches here, it's
> just
> how the cards fell this cycle. I hope you agree with me that they're
> justified fixes.
>
> Here's the boilerplate:
>
> The following changes since commit
> d1abaeb3be7b5fa6d7a1fbbd2e14e3310005c4c1:
>
> Linux 5.3-rc5 (2019-08-18 14:31:08 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
> tags/for-linus
>
> for you to fetch changes up to
> c536277e0db1ad2e9fbb9dfd940c3565a14d9c52:
>
> RDMA/siw: Fix 64/32bit pointer inconsistency (2019-08-23 12:08:27
> -0400)
>
> ----------------------------------------------------------------
> Pull request for 5.3-rc5
>
> - Fix siw buffer mapping issue
> - Fix siw 32/64 casting issues
> - Fix a KASAN access issue in bnxt_re
> - Fix several memory leaks (hfi1, mlx4)
> - Fix a NULL deref in cma_cleanup
> - Fixes for UMR memory support in mlx5 (4 patch series)
> - Fix namespace check for restrack
> - Fixes for counter support
> - Fixes for hfi1 TID processing (5 patch series)
> - Fix potential NULL deref in siw
> - Fix memory page calculations in mlx5
>
> Signed-off-by: Doug Ledford <dledford@xxxxxxxxxx>
>
> ----------------------------------------------------------------
> Bernard Metzler (3):
> RDMA/siw: Fix potential NULL de-ref
> RDMA/siw: Fix SGL mapping issues
> RDMA/siw: Fix 64/32bit pointer inconsistency
>
> Ido Kalir (1):
> IB/core: Fix NULL pointer dereference when bind QP to counter
>
> Jason Gunthorpe (1):
> RDMA/mlx5: Fix MR npages calculation for IB_ACCESS_HUGETLB
>
> Kaike Wan (5):
> IB/hfi1: Drop stale TID RDMA packets
> IB/hfi1: Unsafe PSN checking for TID RDMA READ Resp packet
> IB/hfi1: Add additional checks when handling TID RDMA READ RESP
> packet
> IB/hfi1: Add additional checks when handling TID RDMA WRITE DATA
> packet
> IB/hfi1: Drop stale TID RDMA packets that cause TIDErr
>
> Leon Romanovsky (2):
> RDMA/counters: Properly implement PID checks
> RDMA/restrack: Rewrite PID namespace check to be reliable
>
> Moni Shoua (4):
> IB/mlx5: Consolidate use_umr checks into single function
> IB/mlx5: Report and handle ODP support properly
> IB/mlx5: Fix MR re-registration flow to use UMR properly
> IB/mlx5: Block MR WR if UMR is not possible
>
> Selvin Xavier (1):
> RDMA/bnxt_re: Fix stack-out-of-bounds in
> bnxt_qplib_rcfw_send_message
>
> Wenwen Wang (3):
> IB/mlx4: Fix memory leaks
> infiniband: hfi1: fix a memory leak bug
> infiniband: hfi1: fix memory leaks
>
> zhengbin (1):
> RDMA/cma: fix null-ptr-deref Read in cma_cleanup
>
> drivers/infiniband/core/cma.c | 6 ++-
> drivers/infiniband/core/counters.c | 10 ++--
> drivers/infiniband/core/nldev.c | 3 +-
> drivers/infiniband/core/restrack.c | 15 +++---
> drivers/infiniband/core/umem.c | 7 +--
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 8 ++-
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 11 ++--
> drivers/infiniband/hw/hfi1/fault.c | 12 +++--
> drivers/infiniband/hw/hfi1/tid_rdma.c | 76 ++++++++++-----------
> ------
> drivers/infiniband/hw/mlx4/mad.c | 4 +-
> drivers/infiniband/hw/mlx5/main.c | 6 +--
> drivers/infiniband/hw/mlx5/mem.c | 5 +-
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 14 +++++
> drivers/infiniband/hw/mlx5/mr.c | 7 ++-
> drivers/infiniband/hw/mlx5/odp.c | 17 ++++---
> drivers/infiniband/hw/mlx5/qp.c | 24 +++++++--
> drivers/infiniband/sw/siw/siw.h | 8 +--
> drivers/infiniband/sw/siw/siw_cm.c | 82 ++++++++++++++-------
> ---------
> drivers/infiniband/sw/siw/siw_cq.c | 5 +-
> drivers/infiniband/sw/siw/siw_mem.c | 14 ++---
> drivers/infiniband/sw/siw/siw_mem.h | 2 +-
> drivers/infiniband/sw/siw/siw_qp.c | 2 +-
> drivers/infiniband/sw/siw/siw_qp_rx.c | 26 +++++-----
> drivers/infiniband/sw/siw/siw_qp_tx.c | 80 ++++++++++++++-------
> --------
> drivers/infiniband/sw/siw/siw_verbs.c | 40 +++++++--------
> include/rdma/restrack.h | 3 +-
> 26 files changed, 248 insertions(+), 239 deletions(-)
>
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part