Re: [PATCH] perf c2c: Fix report with offline cpus

[Arnaldo Carvalho de Melo]

Em Thu, Aug 22, 2019 at 12:10:26PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 22, 2019 at 02:20:45PM +0530, Ravi Bangoria wrote:
> > If c2c is recorded on a machine where any cpus are offline,
> > 'perf c2c report' throws an error "node/cpu topology bugFailed
> > setup nodes". It fails because while preparing node-cpu mapping
> > we don't consider offline cpus.
> > 
> > Fixes: 1e181b92a2da ("perf c2c report: Add 'node' sort key")
> > Reported-by: Nageswara R Sastry <nasastry@xxxxxxxxxx>
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
> 
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Thanks, applied.

- Arnaldo
 
> thanks,
> jirka
> 
> > ---
> >  tools/perf/builtin-c2c.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> > index 9e6cc86..fc68a94 100644
> > --- a/tools/perf/builtin-c2c.c
> > +++ b/tools/perf/builtin-c2c.c
> > @@ -2027,7 +2027,7 @@ static int setup_nodes(struct perf_session *session)
> >  		c2c.node_info = 2;
> >  
> >  	c2c.nodes_cnt = session->header.env.nr_numa_nodes;
> > -	c2c.cpus_cnt  = session->header.env.nr_cpus_online;
> > +	c2c.cpus_cnt  = session->header.env.nr_cpus_avail;
> >  
> >  	n = session->header.env.numa_nodes;
> >  	if (!n)
> > -- 
> > 1.8.3.1
> > 

-- 

- Arnaldo