Re: [PATCH] media: saa7134: keep demod i2c gate open on Medion 7134

From: Maciej S. Szmigiero
Date: Tue Aug 20 2019 - 17:43:25 EST


Hi Matthias,

On 20.08.2019 21:54, Matthias Schwarzott wrote:
> Hi Maciej,
>
> some comment about wording in commit message and code-comment.
>
> As far as I know the terms are defined like this:
> * gate open = i2c-clients behind gate can be reached
> * gate closed = i2c-clients behind gate are not reachable

I always thought that this terminology is like the one used for a switch:
if it is closed then the signal can pass, if open then it blocks the
signal but apparently it is literally like a physical gate, so you are
obviously right here - thanks for pointing this out.

Will respin this patch and also add a second one fixing the terminology
already present in saa7134_i2c_eeprom_md7134_gate().

> Regards
> Matthias

Regards,
Maciej