Re: [PATCH v4 3/9] nvmem: core: add nvmem_device_find

[Srinivas Kandagatla]

On 16/08/2019 15:09, Thomas Bogendoerfer wrote:
> On Wed, Aug 14, 2019 at 01:52:49PM +0100, Srinivas Kandagatla wrote:
> > On 14/08/2019 12:46, Thomas Bogendoerfer wrote:
> > > On Tue, 13 Aug 2019 10:40:34 +0100
> > > Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote:
> > > > On 09/08/2019 11:32, Thomas Bogendoerfer wrote:
> > > > > nvmem_device_find provides a way to search for nvmem devices with
> > > > > the help of a match function simlair to bus_find_device.
> > > > >
> > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
> > > > > ---
> > > > >    drivers/nvmem/core.c           | 62 ++++++++++++++++++++++--------------------
> > > > >    include/linux/nvmem-consumer.h |  9 ++++++
> > > > >    2 files changed, 41 insertions(+), 30 deletions(-)
> > > >
> > > > Have you considered using nvmem_register_notifier() ?
> > >
> > > yes, that was the first idea. But then I realized I need to build up
> > > a private database of information already present in nvmem bus. So I
> > > looked for a way to retrieve it from there. Unfortunately I couldn't
> > > use bus_find_device directly, because nvmem_bus_type and struct nvmem_device
> > > is hidden. So I refactured the lookup code and added a more universal
> > > lookup function, which fits my needs and should be usable for more.
> > I see your point.
> >
> > overall the patch as it is look good, but recently we added more generic
> > lookups for DT node, looks like part of your patch is un-doing generic
> > device name lookup.
> >
> > DT node match lookup is in https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/log/?h=generic_lookup_helpers
>
> these patches are not in Linus tree, yet. I guess they will show up
> in 5.4. No idea how to deal with it right now, do you ?
All these patches are due to go in next merge window,
You should base your patch on top of linux-next.

thanks,
srini
> > Other missing bit is adding this api to documentation in
> > ./Documentation/driver-api/nvmem.rst
>
> ok, will do.
>
> Thomas.