Re: [RFC PATCH 08/15] drivers/acrn: add VM memory management for ACRN char device

From: Borislav Petkov
Date: Mon Aug 19 2019 - 03:45:32 EST


On Mon, Aug 19, 2019 at 10:39:58AM +0300, Dan Carpenter wrote:
> On Mon, Aug 19, 2019 at 01:32:54PM +0800, Zhao, Yakui wrote:
> > In fact as this driver is mainly used for embedded IOT usage, it doesn't
> > handle the complex cleanup when such error is encountered. Instead the clean
> > up is handled in free_guest_vm.
>
> A use after free here seems like a potential security problem. Security
> matters for IoT... :(

Yeah, the "S" in "IoT" stands for security.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.