Re: [PATCH v6 5/8] iommu: Add bounce page APIs

[Lu Baolu]

Hi,

On 8/16/19 12:46 PM, Christoph Hellwig wrote:
> On Fri, Aug 16, 2019 at 10:45:13AM +0800, Lu Baolu wrote:
> > Okay. I understand that adding these APIs in iommu.c is not a good idea.
> > And, I also don't think merging the bounce buffer implementation into
> > iommu_map() is feasible since iommu_map() is not DMA API centric.
> >
> > The bounce buffer implementation will eventually be part of DMA APIs
> > defined in dma-iommu.c, but currently those APIs are not ready for x86
> > use yet. So I will put them in iommu/vt-d driver for this time being and
> > will move them to dma-iommu.c later.
>
> I think they are more or less ready actually, we just need more people
> reviewing the conversions.  Tom just reposted the AMD one which will need
> a few more reviews, and he has an older patchset for intel-iommu as well
> that could use a some more eyes.

Good progress and thanks for the update. I prefer that we merge this
patch series first since it addresses the real thunderbolt
vulnerability.

Best regards,
Lu Baolu