RE: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

From: David Laight
Date: Fri Aug 16 2019 - 12:33:42 EST


From: Luck, Tony
> Sent: 16 August 2019 17:29
> >> + * The defined symbol names have the following form:
> >> + * INTEL_FAM6{OPTFAMILY}_{MICROARCH}{OPTDIFF}
> >
> > I think you want to have the underscores in the template:
> >
> > INTEL_FAM6_{OPTFAMILY}_{MICROARCH}_{OPTDIFF}
> >
> > but no need to resend if this is the only issue - I'll fix it up when
> > applying.
>
> I started there, but then had to include a sentence saying to skip the "_"
> if you didn't include either/both of the optional fields.

Might get difficult working out whether INTER_FAM6_FOO_BAR has an
OPTFAMILY of FOO and MICROARCH of BAR, or MICROARCH of FOO and
OPTDIFF of BAR.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)