Re: [PATCH 0/2] Use ccm(aes) aead transform in staging drivers

From: Ard Biesheuvel
Date: Fri Aug 16 2019 - 04:31:35 EST


On Fri, 16 Aug 2019 at 10:00, Christina Quast
<contact@xxxxxxxxxxxxxxxxxx> wrote:
>
> Use ccm(aes) aead transform instead of invoking the AES block cipher
> block by block.
>

Thanks! This eliminates another two users of the bare cipher API,
which is not the right abstraction for drivers to use.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

I don't have the hardware, so I can't test this.

> Christina Quast (2):
> staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API
> ccm(aes)
> staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)
>
> drivers/staging/rtl8192e/Kconfig | 1 +
> drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 187 ++++++++----------
> drivers/staging/rtl8192u/Kconfig | 2 +
> .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 187 ++++++++----------
> 4 files changed, 159 insertions(+), 218 deletions(-)
>
> --
> 2.20.1
>