Re: [PATCH 1/3] drm: add gem ttm helpers

From: Gerd Hoffmann
Date: Wed Aug 07 2019 - 07:51:38 EST


Hi,

> > > > I don't think so. drm_gem_dumb_map_offset() calls
> > > > drm_gem_create_mmap_offset(), which I think is not correct for ttm
> > > > objects because ttm_bo_init() handles vma_node initialization.

> Ok I looked again, and your ttm version seems to exactly match
> drm_gem_dumb_map_offset(),

No. The difference outlined above is still there. See also v2 which
adds an comment saying so.

cheers,
Gerd