Re: [PATCH v3] mlx5: Use refcount_t for refcount

From: Leon Romanovsky
Date: Tue Aug 06 2019 - 23:17:41 EST


On Tue, Aug 06, 2019 at 08:40:11PM +0000, Saeed Mahameed wrote:
> On Tue, 2019-08-06 at 09:59 +0800, Chuhong Yuan wrote:
> > Reference counters are preferred to use refcount_t instead of
> > atomic_t.
> > This is because the implementation of refcount_t can prevent
> > overflows and detect possible use-after-free.
> > So convert atomic_t ref counters to refcount_t.
> >
> > Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
> > ---
> > Changes in v3:
> > - Merge v2 patches together.
> >
> > drivers/infiniband/hw/mlx5/srq_cmd.c | 6 +++---
> > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 6 +++---
> > include/linux/mlx5/driver.h | 3 ++-
> > 3 files changed, 8 insertions(+), 7 deletions(-)
> >
>
> LGTM, Leon, let me know if you are happy with this version,
> this should go to mlx5-next.

Thanks,
Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>