Re: [PATCH 1/4] pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init

From: Krzysztof Kozlowski
Date: Tue Aug 06 2019 - 10:25:59 EST


On Tue, 6 Aug 2019 at 16:15, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Mon, Aug 5, 2019 at 6:27 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> > In exynos_eint_wkup_init() the for_each_child_of_node() loop is used
> > with a break to find a matching child node. Although each iteration of
> > for_each_child_of_node puts the previous node, but early exit from loop
> > misses it. This leads to leak of device node.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> I assume you're collecting these for a pull request to me
> at some later point, all look good to me.

Yes, I'll take these and one more patch from lists and send them to you.

Best regards,
Krzysztof