Re: [PATCH net-next] net: can: Fix compiling warning

From: Dan Carpenter
Date: Tue Aug 06 2019 - 09:53:01 EST


On Fri, Aug 02, 2019 at 10:10:20AM +0200, Oliver Hartkopp wrote:
> On 02/08/2019 05.36, Mao Wenan wrote:
> > There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd
> > and raw_sock_no_ioctlcmd as static.
> >
> > net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static?
> > net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should it be static?
> >
> > Fixes: 473d924d7d46 ("can: fix ioctl function removal")
> >
> > Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>
>
> Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
>
> Thanks Mao!
>
> Btw. what kind of compiler/make switches are you using so that I can see
> these warnings myself the next time?

These are Sparse warnings, not from GCC.

regards,
dan carpenter