Re: [PATCH] MAINTAINERS: Update e-mail address for Andrea Parri

From: James Bottomley
Date: Mon Aug 05 2019 - 14:09:35 EST


On Mon, 2019-08-05 at 10:43 -0700, Paul E. McKenney wrote:
> On Mon, Aug 05, 2019 at 08:23:38AM -0700, James Bottomley wrote:
> > On Mon, 2019-08-05 at 17:15 +0200, Andrea Parri wrote:
> > > > Why don't you also add an entry in .mailmap as Will did in
> > > > commit
> > > > c584b1202f2d ("MAINTAINERS: Update my email address to use
> > > > @kernel.org")?
> > >
> > > I considered it but could not understand its purpose... Maybe
> > > you can explain it to me? ;-) (can resend with this change if
> > > needed/desired).
> >
> > man git-shortlog gives you the gory detail, but its use is to
> > "coalesce together commits by the same person in the shortlog,
> > where their name and/or email address was spelled
> > differently." The usual way this happens is that people have the
> > name that appears in the From field with and without initials.
>
> New one on me, thank you! So I should have a line in .mailmap like
> this?
>
> Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> <paul.mckenney@xxxxxxxx
> rg> <paulmck@xxxxxxxxxxxxx>

Well, you could, but there's no need. As long as your email has 'Paul
E. McKenney' as the text prefix, git-shortlog will do the correct
aggregation without any need for a .mailmap entry. However, if, say,
your linaro email had been

Paul McKenney <paul.mckenney@xxxxxxxxxx>

Then you would need one because git-shortlog would think 'Paul
McKenney' and 'Paul E. McKenney' were two different people.

James