Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return

From: Markus Elfring
Date: Mon Aug 05 2019 - 08:12:03 EST


> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2094,6 +2094,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
> dev_err(dev, "failed to create lane%d phy, %d\n",
> id, ret);
> pm_runtime_disable(dev);
> + of_node_put(child);
> return ret;
> }

I suggest to move a bit of common exception handling code to the end of
this function implementation.
Would you like to add a jump target?

Regards,
Markus