Re: [PATCH 1/2] pinctrl: rockchip: Mark expected switch fall-through

[Linus Walleij]

On Fri, Jul 26, 2019 at 1:28 PM Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:

> When fall-through warnings was enabled by default the following warning
> was starting to show up:
>
> ../drivers/pinctrl/pinctrl-rockchip.c: In function ârockchip_gpio_set_configâ:
> ../drivers/pinctrl/pinctrl-rockchip.c:2783:3: warning: this statement may fall
>  through [-Wimplicit-fallthrough=]
>    rockchip_gpio_set_debounce(gc, offset, true);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/pinctrl-rockchip.c:2795:2: note: here
>   default:
>   ^~~~~~~
>
> Rework so that the compiler doesn't warn about fall-through. Add
> 'return -ENOTSUPP;' to match the comment.
>
> Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij