Re: [PATCH] ARM: dts: meson8b: add ethernet fifo sizes

From: Aymeric
Date: Sun Aug 04 2019 - 15:47:36 EST



Le 23/07/2019 Ã 21:56, Martin Blumenstingl a ÃcritÂ:
> On Thu, Jul 18, 2019 at 11:36 AM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
>> If unspecified in DT, the fifo sizes are not automatically detected by
>> the dwmac1000 dma driver and the reported fifo sizes default to 0.
>> Because of this, flow control will be turned off on the device.
>>
>> Add the fifo sizes provided by the datasheet in the SoC in DT so
>> flow control may be enabled if necessary.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>
> I wonder if this "fixes" some of the performance issues on Odroid-C1
> testing this is now on my TODO-list for the weekend


Good! and maybe that will fix the stability issue I'm seeing when using
the board with a 1 gigabit link! (cf
http://lists.infradead.org/pipermail/linux-amlogic/2019-June/012341.html)

I'll try that asap on my board too :)

Thanks.

--
Aymeric