Re: [PATCH 2/4] counter: new TI eQEP driver

[David Lechner]

On 8/2/19 4:27 AM, William Breathitt Gray wrote:
> > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > index a7e57516959e..ddcbb8573894 100644
> > --- a/drivers/pwm/Kconfig
> > +++ b/drivers/pwm/Kconfig
> > @@ -499,7 +499,7 @@ config  PWM_TIEHRPWM
> >   
> >   config  PWM_TIPWMSS
> >   	bool
> > -	default y if (ARCH_OMAP2PLUS) && (PWM_TIECAP || PWM_TIEHRPWM)
> > +	default y if (ARCH_OMAP2PLUS) && (PWM_TIECAP || PWM_TIEHRPWM || TI_EQEP)
> >   	help
> >   	  PWM Subsystem driver support for AM33xx SOC.
> I was surprised to see this pwm Kconfig change in this patch. Is
> PWM_TIPWMSS required for TI_EQEP to work? If not required, then this
> could be a separate patch; otherwise, put in a mention about why in the
> commit message so that the purpose of this change is clearer.

This enables the parent bus for power management. Since this is the second
comment about this, I wonder if it would make sense to move this out of the
PWM subsystem and into drivers/bus/ since it is no longer exclusive to PWM
devices.