RE: [PATCH][net-next] net/mlx5: remove self-assignment on esw->dev

[Parav Pandit]

> -----Original Message-----
> From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Colin King
> Sent: Friday, August 2, 2019 3:52 PM
> To: Saeed Mahameed <saeedm@xxxxxxxxxxxx>; Leon Romanovsky
> <leon@xxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH][net-next] net/mlx5: remove self-assignment on esw->dev
> 
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> There is a self assignment of esw->dev to itself, clean this up by removing it.
> 
> Addresses-Coverity: ("Self assignment")
> Fixes: 6cedde451399 ("net/mlx5: E-Switch, Verify support QoS element type")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> index f4ace5f8e884..de0894b695e3 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> @@ -1413,7 +1413,7 @@ static int esw_vport_egress_config(struct
> mlx5_eswitch *esw,
> 
>  static bool element_type_supported(struct mlx5_eswitch *esw, int type)  {
Making it const struct mlx5_eswitch *esw brings improves code hygiene further in such functions.

> -	struct mlx5_core_dev *dev = esw->dev = esw->dev;
> +	struct mlx5_core_dev *dev = esw->dev;
> 
>  	switch (type) {
>  	case SCHEDULING_CONTEXT_ELEMENT_TYPE_TSAR:
> --
> 2.20.1