Re: [PATCH v2 2/3] serial: sh-sci: Remove check for specific mctrl_gpio_init() return value

From: Uwe Kleine-König
Date: Thu Aug 01 2019 - 16:39:08 EST


On Thu, Aug 01, 2019 at 06:45:24PM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>
> Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS)
> in cases when CONFIG_GPIOLIB is disabled, we can safely remove this
> check.

I would mention -ENOSYS in the Subject line. Something like:

serial: sh-sci: don't check for mctrl_gpio_init returning -ENOSYS

Now that the mctrl_gpio code returns NULL instead of
ERR_PTR(-ENOSYS) if CONFIG_GPIOLIB is disabled, we can safely
remove this check.

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |