Re: [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h

[Ard Biesheuvel]

On Thu, 1 Aug 2019 at 05:11, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Aug 01, 2019 at 11:53:46AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the crypto tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > scripts/Makefile.asm-generic:25: redundant generic-y found in arch/arm/include/asm/Kbuild: simd.h
> >
> > Introduced by commit
> >
> >   82cb54856874 ("asm-generic: make simd.h a mandatory include/asm header")
> >
> > Also the powerpc ppc64_defconfig build produced this warning:
> >
> > scripts/Makefile.asm-generic:25: redundant generic-y found in arch/powerpc/include/asm/Kbuild: simd.h
>
> Thanks for the heads up Stephen.  This patch should fix the
> warnings.
>
> ---8<---
> Now that simd.h is in include/asm-generic/Kbuild we don't need
> the arch-specific Kbuild rules for them.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Fixes: 82cb54856874 ("asm-generic: make simd.h a mandatory...")
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>
> diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
> index 6b2dc15..68ca86f 100644
> --- a/arch/arm/include/asm/Kbuild
> +++ b/arch/arm/include/asm/Kbuild
> @@ -17,7 +17,6 @@ generic-y += parport.h
>  generic-y += preempt.h
>  generic-y += seccomp.h
>  generic-y += serial.h
> -generic-y += simd.h
>  generic-y += trace_clock.h
>
>  generated-y += mach-types.h
> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
> index 9a1d2fc..64870c7 100644
> --- a/arch/powerpc/include/asm/Kbuild
> +++ b/arch/powerpc/include/asm/Kbuild
> @@ -11,4 +11,3 @@ generic-y += mcs_spinlock.h
>  generic-y += preempt.h
>  generic-y += vtime.h
>  generic-y += msi.h
> -generic-y += simd.h

Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>