Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

From: Andy Shevchenko
Date: Thu Jul 25 2019 - 14:08:47 EST


On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
<info@xxxxxxxxx> wrote:
>
> From: Enrico Weigelt <info@xxxxxxxxx>
>
> The keycode KEY_RESTART is more appropriate for the front button,
> as most people use it for things like restart or factory reset.
>

Should it go as Fixes?

> Signed-off-by: Enrico Weigelt <info@xxxxxxxxx>
> ---
> drivers/platform/x86/pcengines-apuv2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index b0d3110..4138007c 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -93,7 +93,7 @@
>
> static struct gpio_keys_button apu2_keys_buttons[] = {
> {
> - .code = KEY_SETUP,
> + .code = KEY_RESTART,
> .active_low = 1,
> .desc = "front button",
> .type = EV_KEY,
> --
> 1.9.1
>


--
With Best Regards,
Andy Shevchenko