Re: [PATCH 3/8] clk: meson: gxbb: migrate to the new parent description method

[Jerome Brunet]

On Mon 22 Jul 2019 at 11:54, Alexandre Mergnat <amergnat@xxxxxxxxxxxx> wrote:


> @@ -1592,13 +1737,29 @@ static struct clk_regmap gxbb_vid_pll_div = {
>  	.hw.init = &(struct clk_init_data) {
>  		.name = "vid_pll_div",
>  		.ops = &meson_vid_pll_div_ro_ops,
> -		.parent_names = (const char *[]){ "hdmi_pll" },
> +		.parent_data = &(const struct clk_parent_data) {
> +			/*
> +			 * This clock is declared here for GXL and GXBB SoC, so
> +			 * we must use string name to set this parent to avoid
> +			 * pointer issue.
> +			 */

I don't really get the issue with this comment.

How about:

/*
 * Note:
 * gxl and gxbb have different hdmi_plls (with different struct clk_hw).
 * We fallback to the global naming string mechanism so vid_pll_div picks
 * up the appropriate one.
 */

> +			.name = "hdmi_pll",
> +			.index = -1,
> +		},
>  		.num_parents = 1,
>  		.flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
>  	},
>  };