Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

From: Christoph Hellwig
Date: Thu Jul 25 2019 - 14:06:58 EST


On Thu, Jul 25, 2019 at 10:10:08AM -0400, Andrew F. Davis wrote:
> Pages yes, but not "normal" pages from the kernel managed area.
> page_to_pfn() will return bad values on the pages returned by this
> allocator and so will any of the kernel sync/map functions. Therefor
> those operations cannot be common and need special per-heap handling.

Well, that means this thing is buggy and abuses the scatterlist API
and we can't merge it anyway, so it is irrelevant.